-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Ensure correct docPath is resolved when pluginId is passed #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 3.81 MB ℹ️ View Unchanged
|
Visit the preview URL for this PR (updated for commit 1b222a4): https://docusaurus-openapi-36b86--pr277-nw7m722q.web.app (expires Fri, 21 Oct 2022 18:58:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a change to how
docPath
is derived when--plugin-id
is specified via the CLI.Motivation and Context
Prior to this change, the
docPath
was not resolving properly when the--plugin-id
option was passed via the CLI. This occurred because thedocPath
was resolving based on the first OpenAPI plugin instance and did not factor in the specified--plugin-id
value, resulting in a mismatch.How Has This Been Tested?
Tested using a multi-instance and single-instance Petstore API to ensure no regressions bugs were introduced.