Implement NodePolyfillPlugin in theme webpack config #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +59 kB (+1%) Total Size: 6.19 MB
ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit ade49b5): https://docusaurus-openapi-36b86--pr422-viddi9ng.web.app (expires Sun, 12 Mar 2023 18:46:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent update to
@paloaltonetworks/postman-code-generatorsintroduced theurllibrary which requires polyfills for webpack >=5. The theme webpack config didn't have afallbackdefined forurlwhich resulted in the following issue #409. To address #409 and help ensure similar issues don't occur in the future, this PR replaces the previous fallback pattern with theNodePolyfillPluginwhich, ostensibly, handles polyfills for all applicable libraries that require them.Motivation and Context
Fix #409 and help future proof the theme against polyfills-related errors.
How Has This Been Tested?
Tested locally in demo. Besure to
yarn docusaurus clearin between runs.