Fix logo/darkLogo and colorMode synching #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +11.8 kB (0%) Total Size: 6.2 MB
ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit 26e1cb1): https://docusaurus-openapi-36b86--pr426-e9kz1oxj.web.app (expires Thu, 16 Mar 2023 13:54:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
IanVS
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
@sserrata I pulled down your branch and ran yarn build, then copied out the lib and lib-next folders into my own node_modules of my project. It took me a while to figure out I needed to also clear out node_modules/.cache, but after doing that, the correct logo loads up. Change looks good (though you might want to swap out the logo), thanks!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor how logo and darkLogo are handled to ensure sync with
colorMode.Expected behavior/usage:
x-logoandx-dark-logoare definedx-logowill display in light mode andx-dark-logowill display in dark modex-logoorx-dark-logoare defined, the one that is defined will be displayed for both light and dark modesx-logoorx-dark-logoare defined, nothing will be renderedMotivation and Context
Addresses #421
How Has This Been Tested?
See deploy preview Petstore API for test
Types of changes