Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Default categoryLinkSource to none, add auto option #495

Merged
merged 9 commits into from
Mar 15, 2023

Conversation

IanVS
Copy link
Contributor

@IanVS IanVS commented Mar 14, 2023

Description

This sets the default categoryLinkSource to not create a category page, but only create groupings which can be expanded/collapsed. It adds a new option, "auto", to allow the previous default behavior.

Side note: is there a 2.0 migration document somewhere that I should add this to?

Motivation and Context

See #434 (reply in thread)

How Has This Been Tested?

I didn't. :(

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@IanVS IanVS changed the title Default categoryLinkSource to none, add auto option Breaking: Default categoryLinkSource to none, add auto option Mar 14, 2023
@github-actions
Copy link

github-actions bot commented Mar 14, 2023

Visit the preview URL for this PR (updated for commit 9042d19):

https://docusaurus-openapi-36b86--pr495-j4sbs1hu.web.app

(expires Thu, 13 Apr 2023 21:13:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

sserrata
sserrata previously approved these changes Mar 14, 2023
Copy link
Member

@sserrata sserrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@sserrata sserrata dismissed their stale review March 14, 2023 17:51

Breaking changes should probably be merged into v2.0.0 branch. Can you update the PR to merge there instead? Thanks!

@sserrata sserrata changed the base branch from main to v2.0.0 March 14, 2023 21:07
@sserrata sserrata closed this Mar 14, 2023
@sserrata sserrata reopened this Mar 14, 2023
@sserrata
Copy link
Member

@IanVS, I went ahead and changed the base and close/reopened to trigger the pipeline.

@IanVS
Copy link
Contributor Author

IanVS commented Mar 14, 2023

Ah, sorry, missed that comment, and I should have thought of that myself. Thanks for taking care of it.

Copy link
Member

@sserrata sserrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sserrata sserrata merged commit fae5bce into PaloAltoNetworks:v2.0.0 Mar 15, 2023
@IanVS IanVS deleted the default-to-no-links branch March 15, 2023 17:47
renovate bot referenced this pull request in Unleash/unleash Apr 22, 2023
…-beta.2 (#3593)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[docusaurus-plugin-openapi-docs](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs)
| [`2.0.0-beta.1` ->
`2.0.0-beta.2`](https://renovatebot.com/diffs/npm/docusaurus-plugin-openapi-docs/2.0.0-beta.1/2.0.0-beta.2)
|
[![age](https://badges.renovateapi.com/packages/npm/docusaurus-plugin-openapi-docs/2.0.0-beta.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/docusaurus-plugin-openapi-docs/2.0.0-beta.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/docusaurus-plugin-openapi-docs/2.0.0-beta.2/compatibility-slim/2.0.0-beta.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/docusaurus-plugin-openapi-docs/2.0.0-beta.2/confidence-slim/2.0.0-beta.1)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>PaloAltoNetworks/docusaurus-openapi-docs</summary>

###
[`v2.0.0-beta.2`](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/releases/tag/v2.0.0-beta.2)

[Compare
Source](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/compare/v2.0.0-beta.1...v2.0.0-beta.2)

#### What's Changed

- \[UI Enhancement] Restyle tree lines by
[@&#8203;sserrata](https://togithub.com/sserrata) in
[https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/489](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/489)
- \[UI Enhancement] Hide details marker by
[@&#8203;sserrata](https://togithub.com/sserrata) in
[https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/497](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/497)
- Breaking: Default categoryLinkSource to none, add `auto` option by
[@&#8203;IanVS](https://togithub.com/IanVS) in
[https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/495](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/495)
- \[Bug] Add missing status/headers tabs and apply max-height to code by
[@&#8203;sserrata](https://togithub.com/sserrata) in
[https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/517](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/517)
- Prepare release v2.0.0-beta.2 by
[@&#8203;sserrata](https://togithub.com/sserrata) in
[https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/515](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/515)

**Full Changelog**:
PaloAltoNetworks/docusaurus-openapi-docs@v2.0.0-beta.1...v2.0.0-beta.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Unleash/unleash).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuNTcuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot referenced this pull request in Unleash/unleash Apr 23, 2023
…beta.2 (#3594)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[docusaurus-theme-openapi-docs](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs)
| [`2.0.0-beta.1` ->
`2.0.0-beta.2`](https://renovatebot.com/diffs/npm/docusaurus-theme-openapi-docs/2.0.0-beta.1/2.0.0-beta.2)
|
[![age](https://badges.renovateapi.com/packages/npm/docusaurus-theme-openapi-docs/2.0.0-beta.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/docusaurus-theme-openapi-docs/2.0.0-beta.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/docusaurus-theme-openapi-docs/2.0.0-beta.2/compatibility-slim/2.0.0-beta.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/docusaurus-theme-openapi-docs/2.0.0-beta.2/confidence-slim/2.0.0-beta.1)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>PaloAltoNetworks/docusaurus-openapi-docs</summary>

###
[`v2.0.0-beta.2`](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/releases/tag/v2.0.0-beta.2)

[Compare
Source](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/compare/v2.0.0-beta.1...v2.0.0-beta.2)

##### What's Changed

- \[UI Enhancement] Restyle tree lines by
[@&#8203;sserrata](https://togithub.com/sserrata) in
[https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/489](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/489)
- \[UI Enhancement] Hide details marker by
[@&#8203;sserrata](https://togithub.com/sserrata) in
[https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/497](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/497)
- Breaking: Default categoryLinkSource to none, add `auto` option by
[@&#8203;IanVS](https://togithub.com/IanVS) in
[https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/495](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/495)
- \[Bug] Add missing status/headers tabs and apply max-height to code by
[@&#8203;sserrata](https://togithub.com/sserrata) in
[https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/517](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/517)
- Prepare release v2.0.0-beta.2 by
[@&#8203;sserrata](https://togithub.com/sserrata) in
[https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/515](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/515)

**Full Changelog**:
PaloAltoNetworks/docusaurus-openapi-docs@v2.0.0-beta.1...v2.0.0-beta.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Unleash/unleash).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuNTcuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants