[Bug] Fix double scrollbars #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -81 B (0%) Total Size: 6.28 MB
ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit ebe2488): https://docusaurus-openapi-36b86--pr504-zc3wnf16.web.app (expires Wed, 19 Apr 2023 15:29:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Woozl
reviewed
Mar 16, 2023
There was a problem hiding this comment.
Thanks for tackling this so quickly and sorry it slipped by in my first PR. This fixes the scrollbar issue on my machine.
However, on large responses, there's no max-height anymore, so the response block grows to fit the content. Send an API request on this page:
https://docusaurus-openapi-36b86--pr504-zc3wnf16.web.app/petstore_versioned/find-pets-by-status/ with ?status=available
I think it should match the behaviour of the language code blocks:
This is done by on the pre tag, parent of the code element:
|
Also, you should now be able to remove my changes from #417, since this should also fix the language code blocks. Of course, best to double check 😅 |
|
@Woozl, ok, I think all the appropriate changes are in. We'll need to adapt/port these changes over to v2.0.0 once merged. Let me know if everything looks good to you. Thanks! |
Woozl
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #496 for background. Essentially, this change removes redundant styles that are the likely cause of the "double scrollbars" reported by users.
Motivation and Context
Only one set of x/y scrollbars should be visible. Having more than one set is a poor UI/UX.