-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI Enhancement] Add expand button to CodeBlock #537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit dc46889): https://docusaurus-openapi-36b86--pr537-uhujjwis.web.app (expires Sat, 06 May 2023 20:14:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
blindaa121
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Steven! Awesome work 👍
renovate bot
referenced
this pull request
in Unleash/unleash
May 13, 2023
…-beta.3 (#3765) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [docusaurus-plugin-openapi-docs](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs) | [`2.0.0-beta.2` -> `2.0.0-beta.3`](https://renovatebot.com/diffs/npm/docusaurus-plugin-openapi-docs/2.0.0-beta.2/2.0.0-beta.3) | [![age](https://badges.renovateapi.com/packages/npm/docusaurus-plugin-openapi-docs/2.0.0-beta.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/docusaurus-plugin-openapi-docs/2.0.0-beta.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/docusaurus-plugin-openapi-docs/2.0.0-beta.3/compatibility-slim/2.0.0-beta.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/docusaurus-plugin-openapi-docs/2.0.0-beta.3/confidence-slim/2.0.0-beta.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>PaloAltoNetworks/docusaurus-openapi-docs</summary> ### [`v2.0.0-beta.3`](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/releases/tag/v2.0.0-beta.3) [Compare Source](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/compare/v2.0.0-beta.2...v2.0.0-beta.3) #### What's Changed - \[Bug] Narrow SASS loader rules to avoid conflicts with docusaurus-plugin-sass by [@​sserrata](https://togithub.com/sserrata) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/519](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/519) - \[Bug] Patch webpack sass loader by [@​sserrata](https://togithub.com/sserrata) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/521](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/521) - \[Cleanup] Optimize theme typescript build by [@​sserrata](https://togithub.com/sserrata) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/524](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/524) - Update bash/curl logo and refactor how logo width/height are defined by [@​sserrata](https://togithub.com/sserrata) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/525](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/525) - \[UI Enhancement] Move authorization card to ApiItem by [@​sserrata](https://togithub.com/sserrata) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/531](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/531) - \[UI Enhancement] Move CodeTabs above Request by [@​sserrata](https://togithub.com/sserrata) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/533](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/533) - \[UI Enhancement] Restyle schema property labels by [@​sserrata](https://togithub.com/sserrata) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/534](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/534) - \[UI Enhancement] Add expand button to CodeBlock by [@​sserrata](https://togithub.com/sserrata) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/537](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/537) - \[UI Enhancement] Restyle details markers with caret by [@​sserrata](https://togithub.com/sserrata) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/540](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/540) - \[UI Enhancement] Response Examples: Updated styling and support for multiple language variants by [@​blindaa121](https://togithub.com/blindaa121) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/542](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/542) - \[UI Enhancement] Request form validation and updated styling by [@​blindaa121](https://togithub.com/blindaa121) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/530](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/530) - \[UI Enhancement] Enable Expand button for Response by [@​sserrata](https://togithub.com/sserrata) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/553](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/553) - Upgrade demo to 2.4.0 and update supported range in plugin and theme by [@​sserrata](https://togithub.com/sserrata) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/554](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/554) - \[Bug] Improve support for additional properties, cleanup nested `<li>`, support SchemaItem children by [@​sserrata](https://togithub.com/sserrata) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/563](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/563) - \[UI Enhancement] Updated left doc panel styling by [@​blindaa121](https://togithub.com/blindaa121) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/557](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/557) - \[UI Enhancement] ApiDemoPanel: Expand modal cleanup by [@​blindaa121](https://togithub.com/blindaa121) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/566](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/566) - Prepare release v2.0.0-beta.3 by [@​blindaa121](https://togithub.com/blindaa121) in [https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/570](https://togithub.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/570) **Full Changelog**: PaloAltoNetworks/docusaurus-openapi-docs@v2.0.0-beta.2...v2.0.0-beta.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43OS4xIiwidXBkYXRlZEluVmVyIjoiMzUuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces
@theme/CodeBlock
with a custom version that supports expanding code blocks to "full screen". the idea is that the code block will open in a larger modal for easier/improved viewing.Motivation and Context
We're trying to reduce clutter in the demo/explorer panel. Adding the expand option allows us to lower the CodeTabs height while still allowing users to see more of the code snippet.
How Has This Been Tested?
See deploy preview.