Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] Avoid concatenating all tags when grouped by tagGroups #853

Merged

Conversation

ElliotFriend
Copy link
Contributor

@ElliotFriend ElliotFriend commented Jun 26, 2024

Description

Before concatenating the apiTags, operationTags, and schemaTags, the sidebars/index.ts file now checks to make sure that gropuPathsBy is not "tagGroup." This prevents the undesired tag categories from being added to the tagGroup category.

Motivation and Context

As reported in #792, using groupBy: "tagGroups" still leaves the sidebar with extra, undesired tags categories inside each tagGroup category. This PR resolves that, in the v3 branch.

How Has This Been Tested?

Locally, I've inspected the running dev site. I've run yarn test, and everything still passes.

Screenshots (if appropriate)

Screenshot 2024-06-26 at 4 56 48 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link

Visit the preview URL for this PR (updated for commit 38acff3):

https://docusaurus-openapi-36b86--pr853-gn7rvsrm.web.app

(expires Sat, 27 Jul 2024 15:16:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@sserrata sserrata merged commit 0a8aafc into PaloAltoNetworks:v3.0.0 Jun 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants