[V3] Avoid concatenating all tags when grouped by tagGroups #853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before concatenating the
apiTags
,operationTags
, andschemaTags
, thesidebars/index.ts
file now checks to make sure thatgropuPathsBy
is not "tagGroup." This prevents the undesired tag categories from being added to the tagGroup category.Motivation and Context
As reported in #792, using
groupBy: "tagGroups"
still leaves the sidebar with extra, undesired tags categories inside each tagGroup category. This PR resolves that, in the v3 branch.How Has This Been Tested?
Locally, I've inspected the running dev site. I've run
yarn test
, and everything still passes.Screenshots (if appropriate)
Types of changes
Checklist