Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change type of Show optional parameters button #969

Conversation

tuanpt-0634
Copy link
Contributor

@tuanpt-0634 tuanpt-0634 commented Sep 17, 2024

Description

Fix #798

Motivation and Context

The button Show optional parameters is in a form, so it's type is default to submit
.
image

Since, we don't want to submit form in this case, we need to change button type to button.

How Has This Been Tested?

Tested on local env

Screenshots (if appropriate)

To reproduce

docusaurus-openapi-submit-bug-win.mp4

This can be reproduced on https://docusaurus-openapi.tryingpan.dev/cos/list-buckets

After fixed

docusaurus-openapi-submit-bug-fixed-win.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

To avoid submitting form test api
@sserrata
Copy link
Member

Thanks for the contribution @tuanpt-0634! Sometimes one line of code can make all the difference. 🥇

Copy link

Visit the preview URL for this PR (updated for commit bab3b6b):

https://docusaurus-openapi-36b86--pr969-3bhrladz.web.app

(expires Thu, 17 Oct 2024 13:06:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf293780ee827f578864d92193b8c2866acd459f

@sserrata sserrata merged commit 87958a4 into PaloAltoNetworks:main Sep 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API call made on show params
2 participants