Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cngfw azure terraform #568

Merged

Conversation

abudilovskiy-panw
Copy link
Contributor

Description

Updating the Cloud NGFW sections with Cloud NGFW for Azure information and a basic tutorial

Motivation and Context

How Has This Been Tested?

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@abudilovskiy-panw abudilovskiy-panw requested a review from a team as a code owner January 3, 2024 23:59
Copy link

github-actions bot commented Jan 4, 2024

Visit the preview URL for this PR (updated for commit 545f5fa):

https://pan-dev-f1b58--pr568-om2uiq3t.web.app

(expires Sat, 24 Feb 2024 17:53:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9359a9fa100d5fdb082f75280473a90b1f96eb51

Copy link
Member

@migara migara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

products/cloudngfw/docs/getstarted_azure.mdx Outdated Show resolved Hide resolved
products/cloudngfw/docs/getstarted_azure.mdx Outdated Show resolved Hide resolved
products/cloudngfw/docs/getstarted_azure.mdx Outdated Show resolved Hide resolved
products/cloudngfw/docs/getstarted_azure.mdx Outdated Show resolved Hide resolved
abudilovskiy-panw and others added 12 commits January 10, 2024 11:57
Co-authored-by: Migara Ekanayake <2110772+migara@users.noreply.github.com>
Signed-off-by: abudilovskiy-panw <113163070+abudilovskiy-panw@users.noreply.github.com>
Co-authored-by: Migara Ekanayake <2110772+migara@users.noreply.github.com>
Signed-off-by: abudilovskiy-panw <113163070+abudilovskiy-panw@users.noreply.github.com>
Co-authored-by: Migara Ekanayake <2110772+migara@users.noreply.github.com>
Signed-off-by: abudilovskiy-panw <113163070+abudilovskiy-panw@users.noreply.github.com>
Co-authored-by: Migara Ekanayake <2110772+migara@users.noreply.github.com>
Signed-off-by: abudilovskiy-panw <113163070+abudilovskiy-panw@users.noreply.github.com>
Co-authored-by: Migara Ekanayake <2110772+migara@users.noreply.github.com>
Signed-off-by: abudilovskiy-panw <113163070+abudilovskiy-panw@users.noreply.github.com>
Co-authored-by: Migara Ekanayake <2110772+migara@users.noreply.github.com>
Signed-off-by: abudilovskiy-panw <113163070+abudilovskiy-panw@users.noreply.github.com>
Co-authored-by: Migara Ekanayake <2110772+migara@users.noreply.github.com>
Signed-off-by: abudilovskiy-panw <113163070+abudilovskiy-panw@users.noreply.github.com>
Co-authored-by: Migara Ekanayake <2110772+migara@users.noreply.github.com>
Signed-off-by: abudilovskiy-panw <113163070+abudilovskiy-panw@users.noreply.github.com>
Co-authored-by: Migara Ekanayake <2110772+migara@users.noreply.github.com>
Signed-off-by: abudilovskiy-panw <113163070+abudilovskiy-panw@users.noreply.github.com>
Co-authored-by: Migara Ekanayake <2110772+migara@users.noreply.github.com>
Signed-off-by: abudilovskiy-panw <113163070+abudilovskiy-panw@users.noreply.github.com>
@abudilovskiy-panw
Copy link
Contributor Author

Thanks for the thorough review @migara I've resolved the comments.

@abudilovskiy-panw
Copy link
Contributor Author

@migara anything else needed to merge this?

@migara
Copy link
Member

migara commented Jan 25, 2024

@migara anything else needed to merge this?

@abudilovskiy-panw LGTM, feel free to merge it when you're ready!

@abudilovskiy-panw
Copy link
Contributor Author

@migara looks like I don't have write access to do the merge

@jamesholland-uk jamesholland-uk merged commit 5135153 into PaloAltoNetworks:master Jan 25, 2024
6 checks passed
@jamesholland-uk
Copy link
Member

Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants