Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vnet)!: per-subnet sourcing and subnet delegation for CloudNGFW #103

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

acelebanski
Copy link
Contributor

Description

This PR introduces 2 new functionalities to the VNET module:

  • capability to source existing subnets on a per-subnet basis (not all or nothing like previously)
  • subnet delegation to CloudNGFW service (required for VNET-based CloudNGFW deployment)

Motivation and Context

  • need for sourcing some of the subnets and creating rest of them within the same VNET
  • CloudNGFW support

How Has This Been Tested?

By deploying chosen examples manually.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski added the enhancement New feature or request label Oct 9, 2024
@acelebanski acelebanski requested a review from a team as a code owner October 9, 2024 19:30
@acelebanski acelebanski linked an issue Oct 9, 2024 that may be closed by this pull request
@acelebanski acelebanski merged commit 5b91147 into main Oct 10, 2024
77 checks passed
@acelebanski acelebanski deleted the vnet-subnets-enhancement branch October 10, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extend vnet module to introduce subnet delegration
2 participants