Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: code style unification #24

Merged
merged 6 commits into from
Mar 6, 2024
Merged

refactor: code style unification #24

merged 6 commits into from
Mar 6, 2024

Conversation

acelebanski
Copy link
Contributor

@acelebanski acelebanski commented Mar 5, 2024 •
edited
Loading

Description

Fix code style to existing standard.

  • fix the not supported admonitions notation, example: > [!NOTE] to **Note!** \
  • break lines exceeding column 130
  • correct variables description formatting in general
  • Unify "section comments" in examples
  • Unify variables ordering in examples

Motivation and Context

#22

How Has This Been Tested?

No changes to code logic.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski requested a review from a team as a code owner March 5, 2024 19:44
@acelebanski acelebanski added the refactor Related to code refactoring label Mar 5, 2024
sebastianczech
sebastianczech approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍
From cosmetic changes to code style we have huge PR :)

examples/appgw/example.tfvars Show resolved Hide resolved
examples/standalone_panorama/README.md Outdated Show resolved Hide resolved
alperenkose
alperenkose reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@alperenkose alperenkose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work in general, have a few comments.

examples/common_vmseries/.header.md Outdated Show resolved Hide resolved
examples/common_vmseries/README.md Show resolved Hide resolved
examples/common_vmseries/README.md Show resolved Hide resolved
examples/appgw/main.tf Show resolved Hide resolved
@acelebanski acelebanski merged commit 4d388b0 into refactor-modules Mar 6, 2024
@acelebanski acelebanski deleted the refactor_style branch March 6, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianczech sebastianczech sebastianczech approved these changes

@alperenkose alperenkose alperenkose left review comments

Assignees
No one assigned
Labels
refactor Related to code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acelebanski @alperenkose @sebastianczech