Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move appgw and virtual_network_gateway examples to tests directory #42

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Apr 22, 2024

Description

Move appgw and virtual_network_gateway examples into tests folder.

I propose to leave main_test.go as they are currently (validate test, plan test, apply test and idempotence test).
Similarly tests from https://github.com/PaloAltoNetworks/terraform-aws-swfw-modules/tree/main/tests are not included into any GitHub workflow (it's still needed to be developed), so they are not actively used. When we prepare common GitHub workflows for modules integrations tests (not only for AWS, but also for Azure), then we can start extending tests for modules.

Motivation and Context

#41

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech requested a review from a team as a code owner April 22, 2024 07:33
@sebastianczech sebastianczech linked an issue Apr 22, 2024 that may be closed by this pull request
Copy link
Contributor

@acelebanski acelebanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally we could change the name of the appgw test to application_gateway, what do you think? Other than that, I think it's good! 👍

@sebastianczech
Copy link
Contributor Author

Optionally we could change the name of the appgw test to application_gateway, what do you think? Other than that, I think it's good! 👍

Do you propose to change name of the folder in tests or name of the module (folder in modules) ? Now for both of them we have the same name - can we continue that approach ?

@acelebanski
Copy link
Contributor

Optionally we could change the name of the appgw test to application_gateway, what do you think? Other than that, I think it's good! 👍

Do you propose to change name of the folder in tests or name of the module (folder in modules) ? Now for both of them we have the same name - can we continue that approach ?

Oh, okay I see that logic. I'm wondering why we decided to go with shortcuts for things like appgw, natgw, vnet etc. but not with virtual_network_gateway for instance. But nevermind. :)

@sebastianczech sebastianczech merged commit 3b22e32 into refactor-modules Apr 22, 2024
4 checks passed
@sebastianczech sebastianczech deleted the move-to-tests-41 branch April 22, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move appgw and vng examples to tests directory
3 participants