Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix README generation for internal submodules #43

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

acelebanski
Copy link
Contributor

Description

We introduced test_infrastructure module as internal submodule from TF Registry perspective. This means that module's README file should have a leading dot in its name (.README.md). We needed to automate the generation of README files for internal submodules.

This PR introduces separate terraform-docs configuration file for internal submodules and additional terraform-docs hook in pre-commit configuration file for test_infrastructure module.

Motivation and Context

#30

How Has This Been Tested?

Tested locally with pre-commit command.

Screenshots (if appropriate)

The terraform-docs hook is ran twice now, like that:

Screenshot 2024-04-24 at 12 03 31

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski added the refactor Related to code refactoring label Apr 24, 2024
@acelebanski acelebanski requested a review from a team as a code owner April 24, 2024 10:08
@acelebanski acelebanski added the bug Something isn't working label Apr 24, 2024
Copy link
Contributor

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@acelebanski acelebanski merged commit 8ef53fc into refactor-modules Apr 25, 2024
1 check passed
@acelebanski acelebanski deleted the readme_internal_submodules branch April 25, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor Related to code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants