Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vmseries): VMSeries appgw backend pool association #89

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

horiagunica
Copy link
Contributor

@horiagunica horiagunica commented Sep 2, 2024

Description

Motivation and Context

  • No current way to attach existing VMSeries interfaces to AppGW just like you would attach it to a regular Loadbalancer (from within the module).

How Has This Been Tested?

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@horiagunica horiagunica requested a review from a team as a code owner September 2, 2024 09:24
@horiagunica
Copy link
Contributor Author

horiagunica commented Sep 2, 2024

/idempotence paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries" tf_version="1.5 1.6 1.7 1.8"

Testing job ID: 10664590804
Job result: FAILURE
Job result: FAILURE

Copy link
Contributor

@acelebanski acelebanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍
However, we follow a principle in the examples to support all module variables out of the box. Can you also update the variables in the examples? If someone opts to use it, we want him to only add it to tfvars and that's it.

@horiagunica
Copy link
Contributor Author

horiagunica commented Sep 3, 2024

/idempotence paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries" tf_version="1.5 1.6 1.7 1.8"

Testing job ID: 10681102373
Job result: FAILURE

Copy link
Contributor

@acelebanski acelebanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides those little remarks regarding comments, looks great! Thanks! 👍

examples/common_vmseries/variables.tf Outdated Show resolved Hide resolved
modules/vmseries/variables.tf Outdated Show resolved Hide resolved
@acelebanski acelebanski added the enhancement New feature or request label Sep 13, 2024
@acelebanski acelebanski merged commit 54d4961 into main Sep 13, 2024
47 checks passed
@acelebanski acelebanski deleted the appgw_lb_association branch September 13, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for attaching interfaces to AppGW
2 participants