template/template_stack: can't both be enforced yet conflicting #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaloAltoNetworks#294) The template and template_stack objects are enforced when running plan/apply against imported objects; otherwise the engine would want to completely replace the objects, which would likely cause consistency issues with the rest of the configuration. Since they are both enforced; they can't also be conflicting; that leads to an impossible scenario where you must but can't define both a template and template_stack. Signed-off-by: Mathieu Trudel-Lapierre <mtrudel@stack8.com>
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
|
This isn't tested yet, I need to figure out how to build the provider first. I submitted the PR right away to have a discussion if the approach is right; I believe making changes non-destructive is more important than preserving this particular conflict in the schema. |
Signed-off-by: Mathieu Trudel-Lapierre <mtrudel@stack8.com>
|
Yeah, that code change alone doesn't seem to work; I've built the provider and using it locally, but it still complains about conflicts. |
…_stack Signed-off-by: Mathieu Trudel-Lapierre <mtrudel@stack8.com>
Signed-off-by: Mathieu Trudel-Lapierre <mtrudel@stack8.com>
…ama zone Signed-off-by: Mathieu Trudel-Lapierre <mtrudel@stack8.com>
|
@shinmog I think this is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely closes #294
The template and template_stack objects are enforced when running
plan/apply against imported objects; otherwise the engine would
want to completely replace the objects, which would likely cause
consistency issues with the rest of the configuration.
Since they are both enforced; they can't also be conflicting; that
leads to an impossible scenario where you must but can't define
both a template and template_stack.
Signed-off-by: Mathieu Trudel-Lapierre mtrudel@stack8.com
Description
Make these schema fields not conflicting
Motivation and Context
See above
How Has This Been Tested?
I am running this against a subset of my production config with good results (ie. terraform plan shows no changes to be applied when running the proposed code, with template_stack and template both set on panorama-defined zones).
Types of changes
Checklist