Fixed: Allow tags on command line #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 47.47% 47.78% +0.30%
==========================================
Files 11 11
Lines 1070 1082 +12
==========================================
+ Hits 508 517 +9
- Misses 515 517 +2
- Partials 47 48 +1
Continue to review full report at Codecov.
|
primalmotion
suggested changes
May 23, 2020
main.go
Outdated
| @@ -46,6 +46,7 @@ func addPKIXFlags(cmd *cobra.Command) { | |||
| cmd.Flags().StringSlice("address", nil, "Address that will be written the the subject.") | |||
| cmd.Flags().StringSlice("dns", nil, "List of alternate DNS names.") | |||
| cmd.Flags().StringSlice("ip", nil, "List of alternate ips.") | |||
| cmd.Flags().StringSlice("tags", nil, "List of tags.") | |||
There was a problem hiding this comment.
Should be named tag, since we use --tag x --tag y
brianonn
force-pushed
the
support-tags
branch
from
83ae4b4 to
0c4a45f
Compare
kevincantu
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.