Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state.cachedViews.slice error #913

Merged
merged 5 commits into from
Jul 25, 2018
Merged

state.cachedViews.slice error #913

merged 5 commits into from
Jul 25, 2018

Conversation

mimimile
Copy link
Contributor

state.cachedViews -> i type is string slice(begin: number, end: number)

@PanJiaChen
Copy link
Owner

@mimimile 请 git rebase 一下代码。

@mimimile
Copy link
Contributor Author

@PanJiaChen 是这样吗?

@PanJiaChen
Copy link
Owner

不完全对,但不影响。

merge的时候 squash一下就好了。

感谢你的pr~

@PanJiaChen
Copy link
Owner

#487

@PanJiaChen PanJiaChen merged commit 5f20bfc into PanJiaChen:master Jul 25, 2018
@mimimile
Copy link
Contributor Author

@PanJiaChen 我也是刚开始试着提pr
看来要好好再学习下 git 操作 😭

hust-whw added a commit to hust-whw/vue-element-admin that referenced this pull request Aug 16, 2018
* fixed[tagsView]: DEL_OTHERS_VIEWS cachedViews bug (PanJiaChen#913)

* mutations DEL_OTHERS_VIEWS state.cachedViews -> i type is string slice(begin: number, end: number)

* fix[Tinymce]: fixed tinymce upload dialog bug PanJiaChen#654

* [release] 3.7.3

* docs: add gitee

* perf[login.vue]: Improve input background and cursor color (PanJiaChen#927)

* 完善input背景和光标色;

1.完善在Chrome浏览器时登陆界面的input标签 使用记住密码之后颜色和背景不一致;
2.目前的rgb值是 #2d3a4b  修改的rgb值是 #283443;
3.修复光标使用Chrome记录的账号之后变黑色;
4.移除 .title-container .title 重复的font-weight: 400;
5.不用IE我们大家都是好朋友!~

* Update index.vue

* docs: tweak

* tweak

* fix: demo links

* fixBug[waves.js]: wave's position (PanJiaChen#949)

* fixBug[waves.js]-wave's position

* fix[waves.js]-wave's position

* fix typo(PanJiaChen#965)

* update to webpack4 (PanJiaChen#889)

* [release] 3.8.0

* Update README.zh-CN.md

* format code

* docs: change vueAdmin-template => vue-admin-template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants