feat: allow to select from registry list if name is undefined #191
+113
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 84f7e95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chouchouji
force-pushed
the
feat-use-select
branch
from
71573bf
to
868f74f
Compare
|
Thanks @iosh. The test ci worked well. |
|
OK, I will add test to this PR (in this weekend) |
Thanks again. 👍🏻 |
chouchouji
force-pushed
the
feat-use-select
branch
3 times, most recently
from
645c1c0
to
df01cb8
Compare
chouchouji
force-pushed
the
feat-use-select
branch
from
df01cb8
to
3bb88bd
Compare
|
I had merged the pr into this branch. Thanks! But the test ci failed.
@iosh I think this module can be removed. If you think so, please fix it by this branch. |
chouchouji
force-pushed
the
feat-use-select
branch
from
7d56047
to
84f7e95
Compare
|
I fix it. emmmmm
|
chouchouji
commented
Nov 23, 2024
| }); | ||
|
|
||
| expect(message).toBe(`? Please select the registry you want to use (Use arrow keys) | ||
| ${isWin ? '>' : '❯'} npm |
There was a problem hiding this comment.
@iosh It is used to adapt to mac and windows. Otherwise, test ci will fail....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
close #187
Result
use.mp4