Use the recommended way to set the c++ standard via cmake #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
CMakeLists.txt
Outdated
Comment on lines
45
to
47
| if(NOT CMAKE_CXX_STANDARD MATCHES "11|14|17|20") | ||
| message(FATAL_ERROR "Unsupported C++ standard: ${CMAKE_CXX_STANDARD}") | ||
| endif() |
There was a problem hiding this comment.
Thanks for the proposed changes Thomas. My main request here would be to avoid this restriction. We only want to require a minimum standard (at which point the previous set of CMAKE_CXX_STANDARD should be sufficient), not apply future constraints. (We should now be able to make this minimum 17 rather than 11).
AndyChappell
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the recommended
CMAKE_CXX_STANDARDto set the c++ standard instead of adding it to theCMAKE_CXX_FLAGS. Leave the default at11and for now only allow 11, 14, 17 and 20.Effectively the same change as PandoraPFA/PandoraSDK#16