-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate CRA client to vite + react #126
migrate CRA client to vite + react #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions about the underscores might be OBE because I reread your PR summary. We might still leave them to track how to resolve the linting issues.
a7a02d9
to
b0136d8
Compare
@duyminh1998 Applied changes and refactoring for tests. If you could pull and test it out that'll be smooth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes. Pretty much ready to merge.
b0136d8
to
1beb7fa
Compare
Changes
Triage of issues intended to be resolved
1. Migrate from CRA to Vite + React
CRA was deprecated in early 2023. Likewise, Vite or Next.JS are now recommended to use when creating react/client(s)
2. Updating Library/Packages To Latest
I believe I've retained most packages that were used in the previous client
package.json
and updated to latestMaterial UI V6 Upgrade
The migration here wasn't too bad. Followed the docs and most of the style components and core API's haven't changed
Only had to remove and convert deprecated @mui/styles imports to
@mui/systems
3. Resolve Issue #122
Additions