Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault passing mixed types to Vec or Normal constructor #4

Closed
Samuele-Colombo opened this issue Apr 28, 2021 · 0 comments · Fixed by #5
Closed

Segfault passing mixed types to Vec or Normal constructor #4

Samuele-Colombo opened this issue Apr 28, 2021 · 0 comments · Fixed by #5
Assignees
@Paolo97Gll @Samuele-Colombo
Labels
bug Something isn't working

Comments

@Samuele-Colombo
Copy link
Collaborator

Samuele-Colombo commented Apr 28, 2021 •
edited
Loading

If one tries to call the constructor of Vec or Normal, as defined here, with mixed type arguments, Julia enters an infinite recursion until segfault or forced interruption.

Example:
julia> Vec(1, 1., 1.)

This problem is evident in #3
@Samuele-Colombo Samuele-Colombo added the bug Something isn't working label Apr 28, 2021
@Samuele-Colombo Samuele-Colombo mentioned this issue Apr 28, 2021
Merged
15 tasks
Samuele-Colombo added a commit that referenced this issue Apr 28, 2021
@Samuele-Colombo
Add Camera tests (broken, see #4)
8f41259
Samuele-Colombo added a commit that referenced this issue Apr 28, 2021
@Samuele-Colombo
Fix Segfault passing mixed types to constructor #4
11580aa
@Samuele-Colombo Samuele-Colombo mentioned this issue Apr 28, 2021
Merged
@Samuele-Colombo Samuele-Colombo linked a pull request Apr 28, 2021 that will close this issue
Fix issue #4 #5
Merged
Samuele-Colombo added a commit that referenced this issue May 4, 2021
@Samuele-Colombo
Fix Segfault passing mixed types to constructor #4 (#5)
04fe055
Samuele-Colombo added a commit that referenced this issue May 4, 2021
@Paolo97Gll @Samuele-Colombo
Implement image tracer (#3)
d0e59b5 
* Create empty files

* Add Ray implementation and tests

Co-authored-by: Samuele-Colombo <Samuele-Colombo@users.noreply.github.com>

* Add Camera implementation

* Add header

* Add needed exports

Co-authored-by: Samuele-Colombo <Samuele-Colombo@users.noreply.github.com>

* Fix default values for Cameras

* Fix fire_ray

* Add transfor tests for Ray

* Add Camera tests (broken, see #4)

* Declare Camera types with kwdef

Co-authored-by: Paolo Galli <Paolo97Gll@users.noreply.github.com>

* Remove bounds check in fire_ray

* Implement ImageTracer

* Add exports

* Fix Camera tests

* Add ImageTracer tests

Co-authored-by: Samuele-Colombo <Samuele-Colombo@users.noreply.github.com>
Co-authored-by: Samuele-Colombo <79973069+Samuele-Colombo@users.noreply.github.com>
Co-authored-by: Paolo Galli <Paolo97Gll@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Paolo97Gll Paolo97Gll

@Samuele-Colombo Samuele-Colombo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #4 Paolo97Gll/Raytracer.jl
2 participants
@Paolo97Gll @Samuele-Colombo