Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method fire_all_rays returns an upside-down HdrImage #7

Closed
Samuele-Colombo opened this issue May 5, 2021 · 0 comments · Fixed by #9
Closed

Method fire_all_rays returns an upside-down HdrImage #7

Samuele-Colombo opened this issue May 5, 2021 · 0 comments · Fixed by #9
Assignees
@Paolo97Gll @Samuele-Colombo
Labels
bug Something isn't working

Comments

@Samuele-Colombo
Copy link
Collaborator

Samuele-Colombo commented May 5, 2021 •
edited
Loading

A mistake in the fire_ray method of ImageTracer results in an inverted vertical axis
@Samuele-Colombo Samuele-Colombo added the bug Something isn't working label May 5, 2021
Paolo97Gll added a commit that referenced this issue May 5, 2021
@Paolo97Gll
Add test to highlight issue #7
bcbb839
Paolo97Gll added a commit that referenced this issue May 5, 2021
@Paolo97Gll
Add fix position for issue #7 and #8
cee04ad
@Samuele-Colombo Samuele-Colombo mentioned this issue May 5, 2021
Merged
3 tasks
Paolo97Gll added a commit that referenced this issue May 5, 2021
@Paolo97Gll
Fix issue #7
7ca42f2
Samuele-Colombo added a commit that referenced this issue May 5, 2021
@Samuele-Colombo @Paolo97Gll
Fix issue #7 #8 (#9)
f1e1cbc 
* Add test to highlight issue #7

* Add fix position for issue #7 and #8

* Fix issue #7

* Fix issue #8

Co-authored-by: Paolo Galli <49845775+Paolo97Gll@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Paolo97Gll Paolo97Gll

@Samuele-Colombo Samuele-Colombo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #7 #8 Paolo97Gll/Raytracer.jl
2 participants
@Paolo97Gll @Samuele-Colombo