Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an environment variable for velocity secret #6332

Closed
2 tasks done
Cubxity opened this issue Aug 5, 2021 · 4 comments
Closed
2 tasks done

Add an environment variable for velocity secret #6332

Cubxity opened this issue Aug 5, 2021 · 4 comments
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: feature Request for a new Feature. version: 1.17 Game version 1.17

Comments

@Cubxity
Copy link
Member

Cubxity commented Aug 5, 2021

Is your feature request related to a problem?

When deploying Minecraft servers at scale, you would want to automate as much as you can. What I would like to achieve is an immutable Docker image to deploy my Minecraft server. I would like to store Bukkit, Spigot, Paper, etc config inside the Docker image. However, it is not a good idea to store sensitive information like forwarding secret inside a Docker image.

Describe the solution you'd like.

What would be ideal is to have an environment variable that can be defined at runtime, e.g. VELOCITY_FORWARDING_SECRET. This makes it easy to set in an environment like Kubernetes or Docker.

Describe alternatives you've considered.

I have considered templating paper.yml as a ConfigMap with a templating tool like Helm, but this creates an enormous ConfigMap.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported Paper build.

Other

No response

@e-im e-im added good first issue Simple bug fix or feature which would be a good first PR for someone new to the project type: feature Request for a new Feature. version: 1.17 Game version 1.17 labels Aug 5, 2021
@MiniDigger
Copy link
Member

ideally, we would have a full spring like value system, where every config entry can be overridden with a system property or an environment variable, rather than implementing ven vars manually

@Proximyst
Copy link
Contributor

Perhaps moving to pico cli for all config options could help there, alternatively e.g. -paper-merge-config 'yaml file contents here' to merge into the YamlConfiguration before we start parsing?

@stale
Copy link

stale bot commented Oct 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Chew Chew added the status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. label Oct 5, 2021
@stale stale bot removed the resolution: stale label Oct 5, 2021
@e-im e-im removed the good first issue Simple bug fix or feature which would be a good first PR for someone new to the project label Nov 22, 2021
@deniszitu
Copy link

deniszitu commented Feb 13, 2022

Store sensitive information like forwarding secret inside a enviroment variable is a bad ideia, the correct thing is to use a file with the right permissions, like docker secret.

PaperMC/Velocity#463

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: feature Request for a new Feature. version: 1.17 Game version 1.17
Projects
None yet
7 participants