Add environment variable to set velocity secret. #6333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proximyst
suggested changes
Aug 5, 2021
patches/server/0739-Add-environment-variable-to-set-velocity-secret.patch
Outdated
Show resolved
Hide resolved
GreenSlime96
reviewed
Aug 5, 2021
patches/server/0739-Add-environment-variable-to-set-velocity-secret.patch
Show resolved
Hide resolved
|
am kinda meh about this, see #6332 (comment) |
qixils
approved these changes
Aug 7, 2021
There was a problem hiding this comment.
am kinda meh about this
i think a simple, one-variable solution is fine for a config option like this (it literally has secret in the name! wouldn't be good to leak it from uploading your paper.yml to get tech support or something). yes, there is a better way to implement it, but that's a larger and probably low-priority project and it doesn't make sense to delay a potentially important security feature like this (especially one marked as "good first issue" :P)
|
Closing in favor of #6710. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
VELOCITY_SECRETenvironment variable, which can be used as an alternative to the config parameter. (#6332)