Allow using old ender pearl behavior & apply ender pearl exploit patch

[jpenilla]

When enabled, ender pearls will not load chunks and will save to the world instead of the player.

Also changes the exploit config to be default false, as it only makes sense when legacy behavior is enabled.
I didn't bother with a config migration since it won't do anything without legacy behavior enabled.

[kennytv]

Someone else should test it:tm:, but the changes look fine. Bonus points for a telling config name, but I also can't think of one, so that's not a blocker

[Leguan16]

Bonus points for a telling config name

Config name for what? legacyEnderPearlBehaviour? disableEnderpearlLoadChunks or something like that (I think that's the new behaviour or did I miss something?).

[jpenilla]

I chose legacyEnderPearlBehaviour rather than enderPearlsTickChunks as it encompasses more than that, it also affects how pearls are saved and whether they get removed on logout, for example. I think the current name is fine and it should be addressed by docs.

[Owen1212055]

Maybe we could have seperate config options for controlling if they are serialized with the player and tick chunks then?

[jpenilla]

doing that properly would require much more extensive changes, the behaviors are tightly coupled; I also don't see any utility there

[Leguan16]

I chose legacyEnderPearlBehaviour rather than enderPearlsTickChunks as it encompasses more than that, it also affects how pearls are saved and whether they get removed on logout, for example. I think the current name is fine and it should be addressed by docs.

Ok yeah then i don't have another name either.

[ryantheleach]

Naming disablePlayerTickedEnderpearls ? encompasses the fact that enderpearls are loaded and ticked, and player owned by default.

[codebycam]

legacyEnderPearlBehavior is fine IMO. It indicates there has been a change, and people can find more info about it on the docs.

[ryantheleach]

legacyEnderPearlBehavior is fine IMO. It indicates there has been a change, and people can find more info about it on the docs.

As long as enderpearls are never changed again, otherwise you might need a legacyLegacyEnderPearlBehavior.

Personally, anything named 'legacy' or 'old' is a code smell in any coding project, unless it clarifies which legacy behaviour it is almost immediately.

But it's not the worst thing in the world.