Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for org.bukkit.craftbukkit.entity.CraftMinecart#minecartEntityTypeToMaterial #11536

Closed
wants to merge 6 commits into from
Closed

Add test for org.bukkit.craftbukkit.entity.CraftMinecart#minecartEntityTypeToMaterial #11536

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eeb8c37
Add test for org.bukkit.craftbukkit.entity.CraftMinecart#minecartEnti…
Abelkrijgtalles Oct 30, 2024
176218c
Made test not hard-coded and added it to corresponding patch
Abelkrijgtalles Oct 31, 2024
5943982
Add @AllFeatures
Abelkrijgtalles Oct 31, 2024
1c83e3c
Deleted random file
Abelkrijgtalles Oct 31, 2024
b148245
removed empty lines
Abelkrijgtalles Oct 31, 2024
4ad6b38
Revert "removed empty lines"
Abelkrijgtalles Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions patches/server/0448-API-to-get-Material-from-Boats-and-Minecarts.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,53 @@ index ee010d53f8c671d17d68f3f43dca9978e23ac8ab..d35c1a10e58932b19c8053c5dacdc25f
@Override
public AbstractMinecart getHandle() {
return (AbstractMinecart) this.entity;
diff --git a/src/test/java/org/bukkit/craftbukkit/entity/CraftMinecartTest.java b/src/test/java/org/bukkit/craftbukkit/entity/CraftMinecartTest.java
new file mode 100644
index 0000000000000000000000000000000000000000..b05d9ea494cc2518fe2ce1d9107d19b4f50a46a5
--- /dev/null
+++ b/src/test/java/org/bukkit/craftbukkit/entity/CraftMinecartTest.java
@@ -0,0 +1,44 @@
+package org.bukkit.craftbukkit.entity;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Stream;
+import net.minecraft.core.registries.BuiltInRegistries;
+import net.minecraft.resources.ResourceLocation;
+import net.minecraft.world.entity.EntityType;
+import net.minecraft.world.item.Item;
+import net.minecraft.world.item.Items;
+import org.bukkit.support.environment.AllFeatures;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class CraftMinecartTest {
+
+ private static Stream<Arguments> minecartTypesAsArguments() {
+
+ List<Arguments> arguments = new ArrayList<>();
+
+ BuiltInRegistries.ENTITY_TYPE.forEach(type -> {
+ if (type.toShortString().contains("minecart")) {
+ if (type == EntityType.SPAWNER_MINECART) arguments.add(Arguments.of(type, Items.MINECART));
+ else arguments.add(Arguments.of(type, BuiltInRegistries.ITEM.get(ResourceLocation.fromNamespaceAndPath("minecraft", type.toShortString())).get().value()));
+ }
+ });
+
+ return arguments.stream();
+
+ }
+
+ @AllFeatures
+ @ParameterizedTest
+ @MethodSource("minecartTypesAsArguments")
+ void minecartEntityTypeToMaterial(EntityType type, Item material) {
+
lynxplay marked this conversation as resolved.
Show resolved Hide resolved
+ assertEquals(CraftMinecart.minecartEntityTypeToMaterial(type), material, "EntityType %s doesn't match the material %s.".formatted(type.toString(), material.toString()));
+
+ }
+
+}
Loading