Expose particle status client option #11573
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiniDigger
reviewed
Nov 4, 2024
| @@ -60,6 +61,24 @@ index 0000000000000000000000000000000000000000..ed08f823e0620289392f7fc2ff0ac721 | |||
| + return "options.chat.visibility." + this.name; | |||
| + } | |||
| + } | |||
| + | |||
| + public enum ParticleStatus implements Translatable { | |||
There was a problem hiding this comment.
is ParticleStatus a good name for this? maybe ParticleVisibility?
There was a problem hiding this comment.
Yes ParticleVisibility is more explicit, maybe ParticleAmount too idk.
Do you remember when ChatVisibility is unknown? the field doesn't seems to be nullable and is init in the constructor
There was a problem hiding this comment.
cant look at code rn, but theres a time period where the client options arent known to the server yet, right?
There was a problem hiding this comment.
Yes but in that case the player just have the default settings value. So we can't really say when the option is unknown. For example in the PlayerLoginEvent chat visibility is always full.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.