Added API to check if the server is sleeping #11605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See https://github.com/PaperMC/Paper/tree/is-tick-sleeping-api The method names could change to align with the spigot apis, but the impl there is simpler |
|
So should I just implement them? Or what should I do? |
|
As it's not included anymore, I'll close the repo. |
|
I don't understand why this was closed, it should be ok if you copy my impl, it would just need adjusting again after your other pr is merged |
Alright, I'm going to do that once I get home. |
Abelkrijgtalles
force-pushed
the
sleeping_api
branch
from
7d3e2e8 to
cf2709f
Compare
|
I have copied the implementation and rebased. |
Abelkrijgtalles
force-pushed
the
sleeping_api
branch
from
6a1b6a8 to
523ef6d
Compare
jpenilla
reviewed
Nov 15, 2024
patches/server/1065-API-to-check-if-the-server-is-sleeping.patch
Outdated
Show resolved
Hide resolved
|
I have changed the method name, but the API method will stay the same. |
Abelkrijgtalles
force-pushed
the
sleeping_api
branch
4 times, most recently
from
2cb2807 to
ddcea73
Compare
kennytv
approved these changes
Nov 21, 2024
Abelkrijgtalles
force-pushed
the
sleeping_api
branch
from
ddcea73 to
26cdf0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
How are you doing?
I added the API to check if the server is sleeping/paused as requested in #11511.
This pr adds the API function
CraftServer#isPaused(), which is easily accessible usingBukkit#getServer().Under the hood this adds a
paused-variable (falseby default) toMinecraftServer, whichisPaused()now returns (instead of previously justfalse).The
paused-variable gets set totruewhen theServer empty for x seconds, pausing-message gets logged, and set back tofalsewhen the player count isn't 0 (I couldn't find a better way to detect when the server was paused).That's all, have a nice day!