Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide soul speed particles for vanished players #12152

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Hide soul speed particles for vanished players #12152

merged 2 commits into from
Feb 21, 2025

Conversation

bonan
Copy link
Contributor

@bonan bonan commented Feb 19, 2025

Replaces the call to sendParticles() with sendParticlesSource() in SpawnParticlesEffect in order to attribute the effect to the player

@bonan bonan requested a review from a team as a code owner February 19, 2025 00:25
Warriorrrr
Warriorrrr approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@Warriorrrr Warriorrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be nice to modify sendParticlesSource in the future so that it accepts any entity instead of only players (the method itself was added by CB), since entities can be hidden too.

Owen1212055
Owen1212055 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@Owen1212055 Owen1212055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be done by the merger, lgtm.

@notTamion notTamion force-pushed the vanish-soul-particles branch from f495ae2 to 536be38 Compare February 20, 2025 21:32
@lynxplay lynxplay merged commit e5a8ee8 into PaperMC:main Feb 21, 2025
3 checks passed
@bonan bonan deleted the vanish-soul-particles branch February 21, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Owen1212055 Owen1212055 Owen1212055 approved these changes

@lynxplay lynxplay lynxplay approved these changes

@Warriorrrr Warriorrrr Warriorrrr approved these changes

@notTamion notTamion notTamion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Paper PR Queue
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bonan @Owen1212055 @lynxplay @Warriorrrr @notTamion