Use safe method for handling Files#createDirectories #7997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
approved these changes
Jun 24, 2022
electronicboy
approved these changes
Jun 24, 2022
|
(Validated the behavior here using jshell, seems to work as expected here) |
Machine-Maker
requested changes
Jun 24, 2022
Owen1212055
force-pushed
the
fixy-symbolic-config
branch
from
82e0258 to
cfb2659
Compare
Owen1212055
changed the title
|
Updated and fixed, see paper contributing. If anyone knows a better place for this type of util method would be appreciated, but it probably is just fine there? |
Machine-Maker
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7969
Symbolic links seem to not be handled nicely in Files#createDirectories.
There will most likely be a future patch that targets correctly handling symlinks for this method when used in other places in the source code. But I wanted to get this out so that it can specifically target to fix this issue.
There was a bug report on this, but it was marked as NAI: https://bugs.openjdk.org/browse/JDK-8130464