Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TabList#addEntries #987

Merged
merged 1 commit into from
Aug 12, 2023
Merged

feat: add TabList#addEntries #987

merged 1 commit into from
Aug 12, 2023

Conversation

powercasgamer
Copy link
Contributor

Closes #958

powercasgamer
powercasgamer commented Mar 29, 2023
View reviewed changes
api/src/main/java/com/velocitypowered/api/proxy/player/TabList.java
void addEntries(Collection<TabListEntry> entries);

/**
* Adds an array of {@link TabListEntry}'s to the {@link Player}'s tab list.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really like the word "array" here but couldn't come up with something better

@powercasgamer powercasgamer force-pushed the feat/tablist-add-entries branch from 4f4233b to f3ca14b Compare April 3, 2023 13:07
@powercasgamer powercasgamer force-pushed the feat/tablist-add-entries branch from f3ca14b to 4db040f Compare April 3, 2023 13:08
@powercasgamer powercasgamer requested a review from kashike April 11, 2023 15:30
@kashike kashike self-assigned this Aug 12, 2023
@kashike kashike merged commit 81b45d7 into PaperMC:dev/3.0.0 Aug 12, 2023
4drian3d pushed a commit to 4drian3d/Velocity that referenced this pull request Sep 2, 2023
@powercasgamer @4drian3d
feat: add TabList#addEntries (PaperMC#987)
50d65ea
BlackBaroness added a commit to PvPClashnet/Velocity-CommandExecuteEvent that referenced this pull request Oct 24, 2023
@BlackBaroness @Pantera07
@onebeastchris @RealBauHD @powercasgamer @Plugrol @astei @rexlManu @Paul19988 @Redned235 @Gerrygames @electronicboy @Joo200 @4drian3d
Update upstream (#4)
e5cd9f5 
* Add version information for 1.20.1 (PaperMC#1021)

* bump adventure to 4.14.0 (PaperMC#1034)

* check if a plugin has a executor service (PaperMC#1038)

* check if a plugin has an executor service

* checkstyle

* feat: add TabList#addEntries (PaperMC#987)

* [ci skip] Replaced weired i with i in javadocs (PaperMC#1057)

In this little patch I replaced an i which caused my build process to crash with an i

* Do not track plugin channels registered per-player on the proxy (PaperMC#591)

We don't need to track this information since Velocity uses the JoinGame packet, which is about as good of a server rejoin mechanism we're likely to get in vanilla Minecraft.

* fix PaperMC#1062

* 1.20.2 Support (PaperMC#1088)

Co-authored-by: RednedEpic <redned235@gmail.com>
Co-authored-by: Gero <gecam59@gmail.com>

* Actually send plugin message registration to backend servers

I don't see where this was ever done, and don't see how plugin messaging
could of ever worked, at least within the confines of CB and co, given
the fact that we never seemed to be sending this to the backend?

* appease checkstyle, move back to older fix placement

* Change packet decode logging prompt

* Catch throwables when loading plugins (PaperMC#1098)

* Several improvements and fixes for 1.20.2 (PaperMC#1097)

* Send LoginAcknowledged immediately

* Resend player list header/footer after backend server switched to config state

* Fix clearHeaderAndFooter not clearing fields in ConnectedPlayer

* Clear boss bars, header/footer, tab list when switching client to config state

* Send client settings in config state

* Fix unsigned commands detected as signed (PaperMC#1082)

* fix: commands flagged as signed without signed arguments

* feat: improve error message for illegal protocol state.

* acknowledge seen messages to server when running proxy commands (PaperMC#1100)

* Implement ComponentLogger (PaperMC#1022)

* Log the protocol phase in case of trying to obtain a packet id not existing in the phase (PaperMC#1107)

* Bump netty to 4.1.100.Final (PaperMC#1067)

---------

Co-authored-by: Pantera (Mad_Daniel) <89838384+Pantera07@users.noreply.github.com>
Co-authored-by: chris <reichel32574@gmail.com>
Co-authored-by: Aaron <71191102+RealBauHD@users.noreply.github.com>
Co-authored-by: powercas_gamer <cas@deltapvp.net>
Co-authored-by: Groldi <53694440+Plugrol@users.noreply.github.com>
Co-authored-by: Andrew Steinborn <git@steinborn.me>
Co-authored-by: Emmanuel Lampe <rexlmanude@gmail.com>
Co-authored-by: Paul <Paul19988@users.noreply.github.com>
Co-authored-by: RednedEpic <redned235@gmail.com>
Co-authored-by: Gero <gecam59@gmail.com>
Co-authored-by: Shane Freeder <theboyetronic@gmail.com>
Co-authored-by: Joo200 <github@joo200.de>
Co-authored-by: Adrian <68704415+4drian3d@users.noreply.github.com>
@powercasgamer powercasgamer deleted the feat/tablist-add-entries branch May 29, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4drian3d 4drian3d 4drian3d approved these changes

@alexstaeding alexstaeding alexstaeding left review comments

@kashike kashike kashike approved these changes

Assignees

@kashike kashike

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tablist addEntries(List<TabListEntry> entries)
4 participants
@powercasgamer @kashike @alexstaeding @4drian3d