Plugin configurations #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looking nice, only thing I can think of is handling a custom config file, idk if we want to encourage that tho since people mostly use that for storing data and data should be stored in databases instead. oh, and maybe saving configs. |
|
Good points, should now be addressed. |
Owen1212055
approved these changes
Jul 22, 2023
MiniDigger
reviewed
Jul 26, 2023
MiniDigger
reviewed
Jul 26, 2023
|
Deployment failed with the following error: |
|
CI is bugged. This PR is ready for final review and does not actually fail deployment locally |
|
fixed |
NotMyFault
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on a guide for plugin configurations. I made these on a plane so some sections may be lacking. Let me know of any additions needed on the PR or discord :)
closes #105