Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 page bg problem fixed #80

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Chetan-KK
Copy link

fixed #45 issue

created 404 page

@olijeffers0n
Copy link
Member

What was the thought process here as it is essentially the same as the built in one?

@Chetan-KK
Copy link
Author

yes it is same as built in one but i created new 404 page file to fix this problem and then created same 404 page

@MiniDigger
Copy link
Member

I mean the old one looked a bit more fancy with the divider/border and stuff but idk if we care

@olijeffers0n
Copy link
Member

It might be nice to at least match the formatting of the previous 404 page. This way we can just fix the bg colour

@Chetan-KK
Copy link
Author

i can make this 404 page more fancy✨✨

@Chetan-KK
Copy link
Author

new 404 page

Screenshot (196)

@olijeffers0n
Copy link
Member

haha, love it. where is this from? do we need to credit?

@Chetan-KK
Copy link
Author

no, it's free to use as comercial 😄

@lynxplay
Copy link

Could you still link us the source of the image please.

@Chetan-KK
Copy link
Author

here it is: 404 illustration

@olijeffers0n
Copy link
Member

It does state attribution is required

@Chetan-KK
Copy link
Author

state attribute in img?

@Chetan-KK
Copy link
Author

it says free for comercial use

@Chetan-KK
Copy link
Author

i can also make custom one😄

@olijeffers0n
Copy link
Member

Don’t worry about making a custom one. Maybe have a look at the Hangar one?

@Cubxity
Copy link
Member

Cubxity commented Oct 22, 2023

A call-to-action on the 404 page would be nice. An example of this would be to redirect the user to the home page, or something similar. As for illustrations, take a look at unDraw.

@Chetan-KK
Copy link
Author

screenshot

Screenshot (198)

@Chetan-KK
Copy link
Author

@Cubxity have you seen this PR, i've added illustration from unDraw and created an call to action button

@Chetan-KK
Copy link
Author

@Cubxity, is their any issue with my pr

@PaperMC PaperMC deleted a comment from vercel bot Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

next error page changes background
5 participants