-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 page bg problem fixed #80
base: main
Are you sure you want to change the base?
Conversation
What was the thought process here as it is essentially the same as the built in one? |
yes it is same as built in one but i created new 404 page file to fix this problem and then created same 404 page |
I mean the old one looked a bit more fancy with the divider/border and stuff but idk if we care |
It might be nice to at least match the formatting of the previous 404 page. This way we can just fix the bg colour |
i can make this 404 page more fancy✨✨ |
haha, love it. where is this from? do we need to credit? |
no, it's free to use as comercial 😄 |
Could you still link us the source of the image please. |
here it is: 404 illustration |
It does state attribution is required |
state attribute in img? |
it says free for comercial use |
i can also make custom one😄 |
Don’t worry about making a custom one. Maybe have a look at the Hangar one? |
A call-to-action on the 404 page would be nice. An example of this would be to redirect the user to the home page, or something similar. As for illustrations, take a look at unDraw. |
@Cubxity have you seen this PR, i've added illustration from unDraw and created an call to action button |
@Cubxity, is their any issue with my pr |
fixed #45 issue
created 404 page