Skip to content
This repository has been archived by the owner on Sep 22, 2022. It is now read-only.

Prefs: Rewrite for GTK4 #8

Merged
merged 4 commits into from
Jan 11, 2022

Conversation

tadfisher
Copy link

@tadfisher tadfisher commented Dec 23, 2021

Rewrite preferences in GTK4. This may clobber some recent work done on other forks.

TODO:

  • Retain scroll position when adding/removing shortcuts
    • Fixed by replacing TreeListModel with nested ListBox widgets
  • Show shortcut conflicts (they are detected but not wired in to KeybindingsRow)
    • See screenshot below

Screenshots:

image

image

paperwm-1

image

paperwm-2

@tadfisher tadfisher marked this pull request as ready for review December 27, 2021 01:16
@mskorzhinskiy
Copy link

I have tested it a little bit (approx. one day) So far -- nothing to report. A lot of things are working, thank you very much for your work!

@jsravn
Copy link

jsravn commented Jan 6, 2022

Works for me as well. Nice job!

@michaelhthomas
Copy link

Odds are this will fix some of the weird keybinding issues as well. Looks great!

@michaelhthomas michaelhthomas merged commit b66aaf1 into PaperWM-community:next-release Jan 11, 2022
@mogenson
Copy link

I've noticed that this PR still gobbles the Super key and prevents it from being used with shortcuts outside of this extension (eg with Gnome desktop and Gnome shell).

For example, the following shortcuts do not work on Gnome 41.1, with the GTK4 preferences:

gsettings set org.gnome.shell.keybindings toggle-overview "<Super>Space"
gsettings set org.gnome.desktop.wm.keybindings switch-to-workspace-1 "<Super>1"

@tadfisher
Copy link
Author

@mogenson Was this a problem with the current release? I didn't touch the actual shortcut-registering code.

@PaperWM-community PaperWM-community locked and limited conversation to collaborators Jan 24, 2022
@PaperWM-community PaperWM-community unlocked this conversation Jan 24, 2022
@michaelhthomas
Copy link

@mogenson Was this a problem with the current release? I didn't touch the actual shortcut-registering code.

No, it has something to do with the code we merged in at the start of the fork. I'll have to take a crack at that at some point and see what's causing issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants