-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aliases for new tray icons in Plasma 6 #3606
Conversation
Thanks, I still haven't seen the Plasma, so could you add a screenshot how the icons looks on it? |
related to #3595 |
@hexchain I see. This is what I was afraid of. The Plasma 6 uses 22px symbolic icons instead of 16px. Papirus icon theme currently doesn't support it. Of course, we can add it symlinks into panel directory, but it not actually the symbolic icons. The symbolic icons use another classes for coloring warning, error, success. See Monochrome icons in our wiki. So I can't merge it for a while. I have to find the way to deal with that mess. |
@hexchain so, is the |
In the first revision, I was using icons from the symbolic directory but found them to be slightly out of place (subtly bigger?) in the tray. It also lacks the "locked wireless" icons. That's why I switched to using the "panel" icons. As for the |
@hexchain thanks for the info. One more question, are the icons (without |
I don't know the correct answer (as in I'm not sure whether they are designed to use the global color scheme or not), but looking at some icons in this PR in Breeze icons, they seem to support the KDE Color Scheme and they do have elements with related classes: https://invent.kde.org/frameworks/breeze-icons/-/blob/master/icons/status/22/network-wireless-40-locked.svg?ref_type=heads&plain=1 |
@hexchain is the screenshot above with symbolic icons, or not? If these are symbolic icons, please add another screenshot with the icons in PR. |
No, they are not symbolic icons. |
Great. I'll merge this PR later. |
@hexchain May I ask what distro you use to test plasma 6? I'm just curious. I've tried neon unstable in a VM but I don't have a device to install it to. Do you use something like KDE Neon Testing daily already? |
Hi, I use Arch Linux (btw) and have set up a Plasma development environment to build Plasma 6, using this guide. |
@hexchain
Cool! Thanks for the info.
|
@SmartFinn Gentle prod :-) |
Starting in Plasma 6, tray applets will start to use the system icon theme.
This change adds aliases for some of the new icons, using current ones that make sense.