teamId/orgId missing from Segment page events

[jordanh]

Issue - Bug

Investigate why "Loaded a Page" events metadata seem to be missing for some paths (such as /meeting). Likely related to recent routing changes.

[jordanh]

Here's the problem: https://github.com/ParabolInc/action/blob/030809d17a8b614e9c36993ca13f3b6e05651ed2/src/universal/containers/Action/ActionContainer.js#L51

Before the upgrade to react-router-v4 the url params used to be available to the segment page event. Now, that parameter is no longer being passed.

@mattkrick is there a way that ActionContainer can still have access to the object of url parameters for a route? (e.g. if /meeting/:teamId -> { teamId: "abc123" })

[mattkrick]

Absolutely, it should be on the location prop. I'll make a little hotfix shortly

[mattkrick]

ah, now i see what you mean: https://github.com/ParabolInc/action/pull/967/files#diff-8593bb6594d23b08eb1eb9045737df40

we aren't given params by the parent component because v4 is completely modular, so it relies on the child to tell it what those params mean & that child doesn't load before the parent.

so, couple solutions:

• create an object that represents the sitemap. then, given a path, we can extract the params. side benefit is that folks new to the project can get a rough idea of the layout.
• make params a reactive variable (ie stick it in a redux store or similar).
• wrap child routes in a HOC that grabs the previous path from context, matches it to the new path + params & sends it off. this is a more modular approach, but more repetitive since each route would need this logic.

[mattkrick]

i dont like the 1st option because it creates a 2nd source of truth.
2 & 3 don't work out of the box because the modular nature of v4 means that a route gets matched, then rematched, then maybe rematched again. there is no way to tell if the match occurs at the bottom of the tree (1-way data flow & all that jazz, parents don't know about children).
So, what we can do is create a boolean (say bottom) that we pass in to AsyncRoute. Then, that'll get passed on to Bundle. Then, in the bundle, we can call the update function. That means Bundle will need dispatch, which isn't ideal, but not terrible. That way, going to /me doesn't send 3 calls to the endpoint.