Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor teamIds to teamId on Provider schema #1193

Closed
mattkrick opened this issue Aug 2, 2017 · 1 comment
Closed

refactor teamIds to teamId on Provider schema #1193

mattkrick opened this issue Aug 2, 2017 · 1 comment
Assignees

Comments

@mattkrick
Copy link
Member

With some integrations having clickless oauth, there's no value in the original plan of having multiple teams share an oauth token (unless a provider nullifies your old token? we should check with github...)

@mattkrick
Copy link
Member Author

github does not nullify old access tokens, which is great.
currently, we create 1 Provider per TeamMember, so no hard migrations needed.
the main benefit is the speed up for the client, since we don't need to contact parabol to see if they have a provider on another team that can be used.
the benefit for me is that i don't have to iterate over an array of 1 all the time.

mattkrick added a commit that referenced this issue Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant