Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication not completely cleaned-up on logout? #260

Closed
jordanh opened this issue Sep 9, 2016 · 1 comment
Closed

Authentication not completely cleaned-up on logout? #260

jordanh opened this issue Sep 9, 2016 · 1 comment
Assignees
Labels

Comments

@jordanh
Copy link
Contributor

jordanh commented Sep 9, 2016

Issue - Bug

Steps to reproduce:

  1. Login as test user (e.g. jordan@parabol.co)
  2. Logout using gear menu on dashboard
  3. Sign-up as new user
  4. Proceed through welcome wizard
  5. Observe auth failures on server console
@jordanh jordanh added the bug label Sep 9, 2016
@mattkrick
Copy link
Member

This is a symptom of a much larger issue.
Steps required:

  • clear cashay cache on logout
  • remove socket transport on logout
  • use cashay's new @cached for retrieving the user data
  • unsubscribe from changefeeds on logout

To unsubscribe, we have a few options:

  • unsubscribe from each subscription 1 by 1
  • disconnect the socket

The 2nd one sounds best. However, the logout route right now doesn't know about a socket, and I'd like to keep it that way, since being logged in doesn't necessitate a socket (eg welcome wizard, invitation portal).

This is what redux-socket-cluster was kinda built for, but we worked around it by setting the keepAlive to infinity. I've improved it to handle multiple instances of the HOC, so I turned the keepAlive back on.

mattkrick added a commit that referenced this issue Sep 11, 2016
mattkrick added a commit that referenced this issue Sep 12, 2016
@jordanh jordanh removed the pr review label Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants