Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highlighted team no worky #818

Closed
mattkrick opened this issue Mar 15, 2017 · 4 comments · Fixed by #825
Closed

highlighted team no worky #818

mattkrick opened this issue Mar 15, 2017 · 4 comments · Fixed by #825
Assignees
@mattkrick
Labels
bug
Milestone
Epic 2.5 Bugfixes

Comments

@mattkrick
Copy link
Member

this guy again (chrome canary):
screen shot 2017-03-14 at 6 01 18 pm
@mattkrick mattkrick added the bug label Mar 15, 2017
@mattkrick mattkrick added this to the Epic 2.5 Bugfixes milestone Mar 15, 2017
@mattkrick mattkrick self-assigned this Mar 15, 2017
@mattkrick mattkrick mentioned this issue Mar 15, 2017
Merged
9 tasks
@ghost ghost added the pr review label Mar 15, 2017
@mattkrick
Copy link
Member Author

mattkrick commented Mar 17, 2017 •
edited
Loading

hey @ackernaut i tracked this down to src/universal/styles/helpers/makeHoverFocus.js. naive style question, why do we need to do this for :focus?

mattkrick added a commit that referenced this issue Mar 17, 2017
@mattkrick
sigh, router.isActive is impure fix #818
fa92a62
@mattkrick
Copy link
Member Author

fixed. router.isActive needs the react-redux mSTP above it to be impure.

@ackernaut
Copy link
Member

Hey @mattkrick I like making those anchors since they are navigation, and one can tab through those jokers:

record.it
link
gif

@ackernaut
Copy link
Member

So, I make hover/focus have the same styles**

@ghost ghost removed the pr review label Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkrick mattkrick

Labels
bug
Projects
None yet
Milestone
Epic 2.5 Bugfixes
Development

Successfully merging a pull request may close this issue.

Epic2 bugfix ParabolInc/parabol
2 participants
@ackernaut @mattkrick