Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(your-work): Open your work drawer by default #8957

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

jmtaber129
Copy link
Contributor

@jmtaber129 jmtaber129 commented Oct 10, 2023

Description

Fixes #8940

Open the your work drawer by default to attempt to increase feature adoption.

Demo

N/A - see tests

Testing scenarios

  • Open an active standup meeting, and confirm that the your work drawer is open
  • Confirm that clicking either the 'X' or the 'Your work' icon in the top bar closes the drawer
  • Open an ended standup meeting, and confirm that the your work drawer does not open
  • Open a permalinked standup discussion thread (looks like http://localhost:3000/meet/pgc4zNn4go/responses?responseId=teamPromptResponse%3A374, you can get this from a standup notification, such as a mention), and confirm the discussion drawer opens.
  • Confirm that clicking the 'Your work' icon switches the drawer to the your work drawer.

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label One Review Required if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@jmtaber129 jmtaber129 added the Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved label Oct 10, 2023
@jmtaber129 jmtaber129 marked this pull request as ready for review October 10, 2023 22:16
@jmtaber129 jmtaber129 force-pushed the jmtaber129/your-work-open-by-default branch from e6a6fea to 5876bac Compare October 10, 2023 22:25
@jmtaber129 jmtaber129 merged commit 540a6de into master Oct 11, 2023
3 checks passed
@jmtaber129 jmtaber129 deleted the jmtaber129/your-work-open-by-default branch October 11, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Your work: have the drawer open by default
2 participants