Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace react-markdown with markdown-it #900

Closed
mattkrick opened this issue Apr 11, 2017 · 1 comment
Closed

Replace react-markdown with markdown-it #900

mattkrick opened this issue Apr 11, 2017 · 1 comment
Assignees

Comments

@mattkrick
Copy link
Member

react-markdown isn't gonna be powerful enough for what we want because we need to create new nodes based off of new tokens such as #, @, :.
remarkjs/react-markdown#61

What we want is https://yarnpkg.com/en/packages?q=markdown-it
(PS look how awesome yarn makes it to find the most popular packages! npm can just go pound sand.

There isn't a popular react wrapper for it, but i'm assuming that's because all you have to do is
<span dangerouslySetInnerHTML={{__html: this.renderMarkdown(this.props.source)}}/>.

@ackernaut
Copy link
Member

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants