feat: public teams #9057

nickoferrall · 2023-10-26T14:23:26Z

This PR implements a first version of public teams.

Users with the feature flag:

Can see all of the teams in the org
The teams they belong to show up first. The teams they don't belong to are listed below in alphabetical order and have a different UI to indicate that the viewer doesn't belong to the team
Can click on the team and see a "Request to Join" UI
Click a CTA button to join the team

See demo: https://www.loom.com/share/00cae6305c93462d90d32b18601688fd

This PR does not include private teams. If any users are unhappy with public teams, we can remove the feature flag. The modal doesn't include the name of the team the viewer wants to join, but this can be added in a later PR.

A concern I have is that orgs with many teams, like Parabol, may find that the sidebar becomes too crowded with all of the public teams. I think this is better than having a scroll bar within a scroll bar - see Loom example here.

To test

Without the feature flag, see that the UI is the same as production
Add the publicTeams org feature flag
In the sidebar, you can now see teams that you don't belong to
The teams you don't belong to have a different UI, as indicated above
Click the "Request to Join" CTA button and see that the invitation request is sent to users that do belong to that team

acressall · 2023-10-26T15:33:10Z

Left a couple comments on the Loom! I'd like to run this through design maintainer review as well since there's a navigational change. UI is fine, just the UX questions asked in the Loom to sort out

igorlesnenko

Not tested yet, have few questions:

packages/client/mutations/AddTeamMutation.ts

packages/server/graphql/types/Organization.ts

igorlesnenko · 2023-10-30T09:57:00Z

packages/client/components/DashNavList/DashNavList.tsx

+    organizationsRef
+  )
+  const hasPublicTeamsFlag =
+    organizations?.[0]?.viewerOrganizationUser?.user?.featureFlags?.publicTeams


We check feature flag on backend when we return allTeams do we need this check on frontend too?

We do because if we query allTeams and the viewer is a billing leader, all teams in the org will be returned even though they don't have the feature flag. So, we want to check this in the client, and return viewerTeams if they don't have the flag.

I've added a comment in the code to clarify this.

In this case the question is what is the reason to explicitly allow billing leader to see all teams in API while we not allowing to see them on frontend anyway? Should we remove this condition?

In the teams sections of the org settings, billing leaders can see all teams within the org: https://action.parabol.co/me/organizations/Skc7syWwNox/teams

This was a feature requested by the sales team a few months ago.

packages/client/components/DashNavList/DashNavList.tsx

packages/client/components/RequestToJoin.tsx

igorlesnenko

Works!

One small bug that could be done in this or next PR:
If I click on a team and click request to join, and then switch to another team to request that too, it still shows that request already sent

nickoferrall · 2023-10-31T15:43:22Z

If I click on a team and click request to join, and then switch to another team to request that too, it still shows that request already sent

Thanks - fixed!

Dschoordsch

When I request to join a team and the team lead accepts the request, I would like if I would join directly and wouldn't need to accept the invite.

Dschoordsch · 2023-11-01T17:58:57Z

packages/server/graphql/types/Organization.ts

+        if (isBillingLeader || isSuperUser(authToken) || hasPublicTeamsFlag) {
+          const teamIds = allTeamsOnOrg.map((team) => team.id)
+          const isViewerInOrg = teamIds.some((teamId) => user.tms.includes(teamId))
+          if (!isViewerInOrg && !isSuperUser(authToken)) return []


+1 Why is this check necessary now? If I'm not on the org, I shouldn't be able to load this Organization in the first place.

Dschoordsch · 2023-11-01T18:04:43Z

packages/client/modules/teamDashboard/components/EditTeamName/EditableTeamName.tsx

@@ -29,7 +29,7 @@ const EditableTeamName = (props: Props) => {
        teamId: id
        teamName: name
        organization {
-          teams {
+          viewerTeams {


-1 This is used to check for duplicate names in l59, so it should be allTeams here.

Dschoordsch · 2023-11-01T18:08:15Z

packages/client/modules/newTeam/components/NewTeamForm/NewTeamForm.tsx

@@ -117,7 +117,7 @@ const NewTeamForm = (props: Props) => {
        id
        lockedAt
        name
-        teams {
+        viewerTeams {


-1 these teams are used for checking for duplicate names in l159

Dschoordsch

There are a couple minor things

nickoferrall · 2023-11-02T18:58:32Z

When I request to join a team and the team lead accepts the request, I would like if I would join directly and wouldn't need to accept the invite.

Agreed! I'll fix that in another issue: #9108

acressall · 2023-11-02T20:35:01Z

@nickoferrall this went through design review. Designers requested we change the icon to be the same for all and just use the difference in shade to differentiate between the tow.

They also requested that the "invite request" screen would stay for [x] days before reverting to the "request to join" version, to avoid spamming with requests. I suggested this improvement as a fast follow so it doesn't block this PR.

nickoferrall · 2023-11-03T15:44:59Z

Sounds good @acressall. I've updated the icon and created an issue for the request screen: #9117

sentry-io · 2023-11-08T13:55:05Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ TypeError: Cannot read properties of undefined (reading 'flatMap') selectedOrgTeamMemberEmails(packages/client/mod... View Issue
‼️ TypeError: undefined is not an object (evaluating 'e.featureFlags.publicTeams') fn(packages/client/components/DashNavList/DashN... View Issue

_{Did you find this useful? React with a 👍 or 👎}

nickoferrall added 11 commits October 25, 2023 19:38

show all teams in org in sidebar

9ed1f5a

convert request to join to tailwind

0c04ccb

send request to join

f92ca54

add user feature flag

721f687

update public team dash nav ui

0a7c819

show correct ui after creating an org or team

9df1b17

ensure user belongs to org

684c205

fix ui on mobile

69cfc1d

add client segment event

aaac945

split org.teams into allTeams and viewerTeams

77de7ac

remove viewer from team

3cca606

github-actions bot added the size/m label Oct 26, 2023

nickoferrall requested review from igorlesnenko and acressall October 26, 2023 14:27

igorlesnenko reviewed Oct 30, 2023

View reviewed changes

nickoferrall added 2 commits October 30, 2023 16:53

make public teams an org feature flag

8fa8d8b

merge with master

bcca919

nickoferrall requested a review from igorlesnenko October 30, 2023 17:01

igorlesnenko approved these changes Oct 31, 2023

View reviewed changes

nickoferrall added 2 commits October 31, 2023 14:46

render a unique requestToJoin component

bcc6fb7

add public teams fragment

cf43049

nickoferrall requested a review from Dschoordsch October 31, 2023 15:43

Dschoordsch approved these changes Nov 1, 2023

View reviewed changes

Dschoordsch requested changes Nov 1, 2023

View reviewed changes

nickoferrall mentioned this pull request Nov 2, 2023

Public Teams: users that requests invite doesn't need to confirm acceptance #9108

Closed

1 task

replace viewerTeams with allTemas in new team form

d1a900f

nickoferrall requested a review from Dschoordsch November 2, 2023 18:58

Dschoordsch approved these changes Nov 2, 2023

View reviewed changes

remove groupAll icon from public teams

df50af8

nickoferrall mentioned this pull request Nov 3, 2023

Public Teams: invite request screen stays for x days #9117

Closed

1 task

nickoferrall merged commit b8c703c into master Nov 3, 2023
3 checks passed

nickoferrall deleted the feat/public-teams branch November 3, 2023 15:50

github-actions bot mentioned this pull request Nov 3, 2023

chore(release): release v7.6.0 #9106

Merged

mattkrick mentioned this pull request Nov 3, 2023

fix: reference to SendClientSideEvent #9119

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: public teams #9057

feat: public teams #9057

nickoferrall commented Oct 26, 2023 •

edited

Loading

acressall commented Oct 26, 2023

igorlesnenko left a comment

igorlesnenko Oct 30, 2023

nickoferrall Oct 30, 2023

igorlesnenko Oct 31, 2023

nickoferrall Oct 31, 2023

igorlesnenko left a comment

nickoferrall commented Oct 31, 2023

Dschoordsch left a comment

Dschoordsch Nov 1, 2023

Dschoordsch Nov 1, 2023

Dschoordsch Nov 1, 2023

Dschoordsch left a comment

nickoferrall commented Nov 2, 2023

acressall commented Nov 2, 2023

nickoferrall commented Nov 3, 2023

sentry-io bot commented Nov 8, 2023 •

edited

Loading

feat: public teams #9057

feat: public teams #9057

Conversation

nickoferrall commented Oct 26, 2023 • edited Loading

To test

acressall commented Oct 26, 2023

igorlesnenko left a comment

Choose a reason for hiding this comment

igorlesnenko Oct 30, 2023

Choose a reason for hiding this comment

nickoferrall Oct 30, 2023

Choose a reason for hiding this comment

igorlesnenko Oct 31, 2023

Choose a reason for hiding this comment

nickoferrall Oct 31, 2023

Choose a reason for hiding this comment

igorlesnenko left a comment

Choose a reason for hiding this comment

nickoferrall commented Oct 31, 2023

Dschoordsch left a comment

Choose a reason for hiding this comment

Dschoordsch Nov 1, 2023

Choose a reason for hiding this comment

Dschoordsch Nov 1, 2023

Choose a reason for hiding this comment

Dschoordsch Nov 1, 2023

Choose a reason for hiding this comment

Dschoordsch left a comment

Choose a reason for hiding this comment

nickoferrall commented Nov 2, 2023

acressall commented Nov 2, 2023

nickoferrall commented Nov 3, 2023

sentry-io bot commented Nov 8, 2023 • edited Loading

Suspect Issues

nickoferrall commented Oct 26, 2023 •

edited

Loading

sentry-io bot commented Nov 8, 2023 •

edited

Loading