Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reference to SendClientSideEvent #9119

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

mattkrick
Copy link
Member

Description

fixes borked master

From slack rant:

master is broken right now! It looks like our GitHub strategy is to blame:
The error is Can't resolve '../mutations/SendClientSideEvent'
This is because #9067 changed the location of that file
And #9057 referenced the old location
The root cause is that we don’t require PRs be brought up to date before we allow them to be merged. For example, I open a PR, the checks pass, someone else’s PR gets merged which would cause my PR to break, but since my checks already passed, I can merge & break master

Signed-off-by: Matt Krick <matt.krick@gmail.com>
@mattkrick mattkrick merged commit 1607fb6 into master Nov 3, 2023
4 checks passed
@mattkrick mattkrick deleted the fix/send-client-event-ref branch November 3, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant