Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trial expiration date bug #914

Closed
tayamueller opened this issue Apr 14, 2017 · 5 comments · Fixed by #1011
Closed

Trial expiration date bug #914

tayamueller opened this issue Apr 14, 2017 · 5 comments · Fixed by #1011
Assignees
Labels
Milestone

Comments

@tayamueller
Copy link
Contributor

Issue - Bug

I expired 2 days ago but everything is still functional:

screenshot 2017-04-14 at 2 32 37 pm

@jordanh jordanh changed the title Zombie Account Trial expiration date bug Apr 18, 2017
@jordanh jordanh added the bug label Apr 18, 2017
@mattkrick
Copy link
Member

We didn't have a production endpoint set up for stripe so we weren't capturing any webhooks!!!
To remedy this we'll need to:

  • add the webhook endpoint on stripe
  • write a migration (or a cron job?) to get caught up on all the webhooks we've missed

@mattkrick
Copy link
Member

Steps for migration:

  1. Modify invoiceCreated to adjust status if the invoice has already been paid or failed.
  2. get all invoices from slack. filter out the recently created good ones by removing any IDs that exist in the parabol DB.
  3. process them 1-by-1 using invoiceCreated webhook. go in serial & not parallel to avoid any rate limiting that stripe might impose (should take < 20 mins).

@jordanh the only headache is that i'm not sure how we could do a dry run. Stripe intentionally won't let us load prod data into their testing DB. Any thoughts?

@mattkrick
Copy link
Member

mattkrick commented Jun 10, 2017

hey @ackernaut were you seeing this locally on the draft branch or in production?

oh man, we got ourselves a race condition! if you blow through step 3 in less than .25 seconds, you can reproduce reliably

@mattkrick mattkrick reopened this Jun 10, 2017
@ackernaut
Copy link
Member

@mattkrick oh good—you figured it out! Yep, I would type “Terry”, “Teaming”, and then quickly tab to the “kick the tires” link and press enter. http://recordit.co/Lrl4Dv9Kfm

@jordanh jordanh modified the milestones: Epic 11+: The Future, Epic 4.5 Bugfixes Jun 20, 2017
@mattkrick mattkrick reopened this Jun 27, 2017
@mattkrick
Copy link
Member

@jordanh i think this got erroneously closed by the force push. if i'm wrong feel free to close again

@ghost ghost added the pr review label Jun 27, 2017
@ghost ghost removed the pr review label Jun 27, 2017
jordanh added a commit that referenced this issue Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants