Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orgAdmins): Make org members view sortable #10146

Merged
merged 17 commits into from
Sep 3, 2024

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Aug 20, 2024

Description

Sort organization members by email (alphabetically) or last seen date. Discussion of the design iteration can be found here

Demo

2024-08-22 11 36 23

Testing scenarios

  • Sortable org members view
    • Go to the org members page: http://localhost:3000/me/organizations/xxxx/members
    • Verify that you can sort the members by their emails
    • Verify that you can sort the members by last seen date

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe changed the title feat/orgMemberLastMetAt feat(orgAdmins): Modify the org members table to be sortable by lastMetAt Aug 20, 2024
@tianrunhe tianrunhe changed the title feat(orgAdmins): Modify the org members table to be sortable by lastMetAt feat(orgAdmins): Make org members view sortable Aug 21, 2024
@tianrunhe tianrunhe merged commit 97bb948 into master Sep 3, 2024
6 checks passed
@tianrunhe tianrunhe deleted the feat/orgMemberLastMetAt branch September 3, 2024 18:31
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants