chore(rethinkdb): Comment: Phase 1 #10166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Writes to PG
Comment is a tricky table to migrate.
Today, if a user gets hard deleted, we set the Comment’s userId to a tombstone (e.g. DELTED:local|123345).
In PG, every userId needs to reference a valid User.
We can relax that constraint & make userId nullable.
Alternatively, we can change the reference to a dummy userId like "A deleted User", but if we can avoid a dummy user, that would keep things simple.
Alternatively, we can delete that comment, but then all replies will have to have their threadParentId set to null, so the discussion shape would change dramatically.
Making userId seems to be the least obtrusive option.