fix: move to rrule-rust #10181
Merged
fix: move to rrule-rust #10181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Dschoordsch
approved these changes
Sep 10, 2024
| dayjs.extend(utcPlugin) | ||
| dayjs.extend(timezonePlugin) | ||
|
|
||
| // the RRule package requires dstart to be a date object set to a negative UTC offset. It's ugly! |
There was a problem hiding this comment.
+1 I don't see where we set a negative UTC offset here or what that means.
There was a problem hiding this comment.
Same as the old helper functions in this file, the rrule package stores dtstart as a Date, but interprets the local time as UTC time. e.g. it'll create a Date of 1/1/2020 8:00AM PST and then interpret that as 1/1/2020 8:00AM UTC. It's pants-on-head stupid. jkbrzt/rrule#501 (comment).
The best thing we can do is use dayjs everywhere we can since it supports timezones & then when we have to ocnvert it to an rrule, we use the helper function.
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #9722
rrule is stalling our gql executor whenever it runs. since it is sychronous, that means all pending requests get timed out.
there's a rust version without the bugs, so this moves to that.
The API is different, primarily dtstart and tzid only exist on RRuleSet.
Additionally, I found a ton of bugs with how we were handling timezones, so I fixed the ones I could find.
Most notably is how we handle timezones on the client.
Before, when you edited a rrule that was created in a different timezone, it kept the time the same, so it reported 11PM eastern as 11PM pacific.
Now it reports that accurately.
TEST