Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orgAdmin): user should be able to remove themselves from the org #10201

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Sep 9, 2024

Description

Fixes 🔒the issue where user cannot remove themselves from the org

Demo

Screenshot 2024-09-09 at 13 51 41

Testing scenarios

  • User remove themselves
    • Logged in as a normal user without billing leader or org admin role
    • Go to http://localhost:3000/me/organizations/xxxx/members
    • Observe the 3-dot menu icon at the user row
    • Click it and see you can remove yourself

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@mattkrick
Copy link
Member

great catch!

@mattkrick mattkrick merged commit 4368c0b into master Sep 9, 2024
8 checks passed
@mattkrick mattkrick deleted the bug/orgMemberSelfRemove branch September 9, 2024 21:37
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants