-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): add mutation to generate usage report #10236
Conversation
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get some strange results with the month end date
{
"monthStart": "2024-03-01T00:00:00.000Z",
"lastDayOfMonth": "2024-03-30T23:00:00.000Z",
"orgName": "All Organizations",
"signupCount": 0,
"loginCount": 0,
"participantCount": 0,
"meetingCount": 0
},
{
"monthStart": "2024-04-01T00:00:00.000Z",
"lastDayOfMonth": "2024-04-29T22:00:00.000Z",
"orgName": "All Organizations",
"signupCount": 0,
"loginCount": 0,
"participantCount": 0,
"meetingCount": 0
},
Note the time.
Also if I query for endDate: "2024-09-16T00:00:00.000Z"
I get the result as
{
"monthStart": "2024-09-01T00:00:00.000Z",
"lastDayOfMonth": "2024-09-29T22:00:00.000Z",
which is misleading, because we only count till the end date. I propose removing the lastDayOfMonth
field.
packages/server/graphql/private/typeDefs/runOrgActivityReport.graphql
Outdated
Show resolved
Hide resolved
packages/server/graphql/private/typeDefs/runOrgActivityReport.graphql
Outdated
Show resolved
Hide resolved
I updated the code to remove the p.s. Also updated the screenshot & test GraphQL query |
Description
Fixes #10001
The spec did mention another argument
orgId
to filter with a particular org but I don't want to get too complicated in the first version, especially considering in a month this query has to be re-written when we fully migratedMeetingMember
andNewMeeting
table to PG.Demo
Testing scenarios
Final checklist