fix(misc): show full length of agenda item text when hovering #10251
Conversation
tianrunhe
added
the
Skip Maintainer Review
There was a problem hiding this comment.
You assigned me to the PR but I assume you meant reviewer, so here is my review 😄
Ideally, I think we should only show the tooltip when you can't see the entire agenda item. Most of the time, you can read the full agenda item, so you wouldn't want to see a tooltip: https://www.loom.com/share/498faf0911d24118a8fab147678cd953
| @@ -238,7 +238,9 @@ const AgendaItem = (props: Props) => { | |||
| /> | |||
| </AgendaItemStyles> | |||
| {tooltipPortal( | |||
| pinned ? `Unpin "${content}" from every check-in` : `Pin "${content}" to every check-in` | |||
| pinned | |||
| ? `Unpin this agenda topic from every check-in` | |||
There was a problem hiding this comment.
+1 why remove the "content" bit out of interest? The tooltip updates the position so we can always see it. I prefer being able to see the content of the tooltip I'm pinning so I'm sure I'm pinning the right one
There was a problem hiding this comment.
I find it redundant & too verbose? I'm trying to follow a "industry standard" (if that's a thing😂). For example, in Arc tab management:
Notice here it says "archive this tab", not "archive 'GitHub'"
Sorry for randomly assigning work to you, this is what happened when you go on a vacation and back 🤣! |
Demo
Testing scenarios
Agenda Item at team dash
Agenda Item in check-in meeting
Final checklist